Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

fix(deps): fix "too much recursion" error with circular deps #2899

Merged
merged 1 commit into from
Mar 6, 2020
Merged

fix(deps): fix "too much recursion" error with circular deps #2899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,23 +134,23 @@
"bundlesize": [
{
"path": "packages/react-instantsearch/dist/umd/Core.min.js",
"maxSize": "2.75 kB"
"maxSize": "2.95 kB"
},
{
"path": "packages/react-instantsearch/dist/umd/Connectors.min.js",
"maxSize": "21.5 kB"
"maxSize": "21.75 kB"
},
{
"path": "packages/react-instantsearch/dist/umd/Dom.min.js",
"maxSize": "34 kB"
"maxSize": "34.25 kB"
},
{
"path": "packages/react-instantsearch-core/dist/umd/ReactInstantSearchCore.min.js",
"maxSize": "25 kB"
"maxSize": "25.25 kB"
},
{
"path": "packages/react-instantsearch-dom/dist/umd/ReactInstantSearchDOM.min.js",
"maxSize": "36.50 kB"
"maxSize": "36.75 kB"
},
{
"path": "packages/react-instantsearch-dom-maps/dist/umd/ReactInstantSearchDOMMaps.min.js",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-instantsearch-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"dependencies": {
"@babel/runtime": "^7.1.2",
"algoliasearch-helper": "^3.1.0",
"fast-deep-equal": "^2.0.1",
"react-fast-compare": "^3.0.0",
"prop-types": "^15.5.10"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-instantsearch-core/src/connectors/connectInfiniteHits.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isEqual from 'fast-deep-equal';
import isEqual from 'react-fast-compare';

import createConnector from '../core/createConnector';
import {
Expand Down
2 changes: 1 addition & 1 deletion packages/react-instantsearch-core/src/core/createConnector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { Component, ReactType } from 'react';
import isEqual from 'fast-deep-equal';
import isEqual from 'react-fast-compare';
import { shallowEqual, getDisplayName, removeEmptyKey } from './utils';
import {
InstantSearchConsumer,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-instantsearch-core/src/widgets/InstantSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { Component, Children } from 'react';
import isEqual from 'fast-deep-equal';
import isEqual from 'react-fast-compare';
import PropTypes from 'prop-types';
import createInstantSearchManager from '../core/createInstantSearchManager';
import { InstantSearchProvider, InstantSearchContext } from '../core/context';
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15864,6 +15864,11 @@ react-fast-compare@^2.0.2:
resolved "https://registry.yarnpkg.com/react-fast-compare/-/react-fast-compare-2.0.4.tgz#e84b4d455b0fec113e0402c329352715196f81f9"
integrity sha512-suNP+J1VU1MWFKcyt7RtjiSWUjvidmQSlqu+eHslq+342xCbGTYmC0mEhPCOHxlW0CywylOC1u2DFAT+bv4dBw==

react-fast-compare@^3.0.0:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come nothing is removed from the lockfile? Does another package already use it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Storybook.

version "3.0.1"
resolved "https://registry.yarnpkg.com/react-fast-compare/-/react-fast-compare-3.0.1.tgz#884d339ce1341aad22392e7a88664c71da48600e"
integrity sha512-C5vP0J644ofZGd54P8++O7AvrqMEbrGf8Ue0eAUJLJyw168dAX2aiYyX/zcY/eSNwO0IDjsKUaLE6n83D+TnEg==

react-focus-lock@^1.17.7:
version "1.18.3"
resolved "https://registry.yarnpkg.com/react-focus-lock/-/react-focus-lock-1.18.3.tgz#19d84afeab935c0b5de196922f71db7c481baba4"
Expand Down