This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(searchbox): add maxlength 512 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API can only handle queries up to 512 characters and would throw an error in this case (copy pasted addresses for example). This prevents users from typing more than possible, and would simply discard later characters fixes #510 (haha would be funny is that was issue 512) supported in all browsers, but would fall back nicely anyway: http://caniuse.com/#feat=maxlength cc @67ideas
|
Deploy preview ready! Built with commit fb98095 |
|
Apparently you should use |
samouss
added a commit
that referenced
this pull request
Nov 2, 2017
<a name="4.2.0"></a> # [4.2.0](v4.1.3...v4.2.0) (2017-11-02) ### Bug Fixes * **connectRange:** handle boundaries on first call ([9f14dc0](9f14dc0)) * **connectRange:** use refine instead of cleanUp in metadata ([#526](#526)) ([1861235](1861235)) * **hierarchicaMenu:** allow sorting and using limit ([fe178ed](fe178ed)), closes [#92](#92) * **InfiniteHits:** add disabled style to the LoadMore button ([#477](#477)) ([faba1ad](faba1ad)) * **Range:** handle float, allow reset and respect boundaries ([75969b8](75969b8)) * **RangeInput:** fix compatibility with React 16 & Panel ([3f218db](3f218db)) * **searchbox:** add maxlength 512 ([#542](#542)) ([5bd4033](5bd4033)), closes [#510](#510) ### Features * **MenuSelect:** add component and connector ([cc6e0d7](cc6e0d7))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The API can only handle queries up to 512 characters and would throw an error in this case (copy pasted addresses for example).
Result
This prevents users from typing more than possible, and would simply discard later characters
fixes #510 (haha would be funny is that was issue 512)
supported in all browsers, but would fall back nicely anyway: http://caniuse.com/#feat=maxlength
cc @67ideas