Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

fix(searchbox): add maxlength 512 #542

Merged
merged 6 commits into from
Nov 2, 2017
Merged

fix(searchbox): add maxlength 512 #542

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da42a15
fix(searchbox): add maxlength 512
Haroenv Oct 31, 2017
d51be4c
use maxLength instead of maxlength :react:
Haroenv Nov 1, 2017
68b3b13
Merge branch 'master' into searchbox/maxlength
Haroenv Nov 1, 2017
67e67f1
update snapshots
Haroenv Nov 1, 2017
174939b
😶
Haroenv Nov 1, 2017
fb98095
Merge branch 'master' into searchbox/maxlength
mthuret Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-instantsearch/src/components/SearchBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ class SearchBox extends Component {
autoCapitalize="off"
spellCheck="false"
required
maxLength="512"
value={query}
onChange={this.onChange}
{...searchInputEvents}
Expand Down
3 changes: 3 additions & 0 deletions packages/react-instantsearch/src/components/__snapshots__/Menu.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ exports[`Menu Menu with search inside items but no search results 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down Expand Up @@ -219,6 +220,7 @@ exports[`Menu Menu with search inside items with search results 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down Expand Up @@ -340,6 +342,7 @@ exports[`Menu applies translations 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="placeholder"
required={true}
Expand Down
3 changes: 3 additions & 0 deletions packages/react-instantsearch/src/components/__snapshots__/RefinementList.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ exports[`RefinementList applies translations 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="placeholder"
required={true}
Expand Down Expand Up @@ -309,6 +310,7 @@ exports[`RefinementList refinement list with search inside items but no search r
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down Expand Up @@ -491,6 +493,7 @@ exports[`RefinementList refinement list with search inside items with search res
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down
7 changes: 7 additions & 0 deletions packages/react-instantsearch/src/components/__snapshots__/SearchBox.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ exports[`SearchBox applies its default props 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down Expand Up @@ -138,6 +139,7 @@ exports[`SearchBox lets you customize its theme 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down Expand Up @@ -228,6 +230,7 @@ exports[`SearchBox lets you customize its translations 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="PLACEHOLDER"
required={true}
Expand Down Expand Up @@ -318,6 +321,7 @@ exports[`SearchBox lets you give custom components for reset and submit 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down Expand Up @@ -400,6 +404,7 @@ exports[`SearchBox transfers the autoFocus prop to the underlying input element
autoCorrect="off"
autoFocus={true}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down Expand Up @@ -490,6 +495,7 @@ exports[`SearchBox treats its query prop as its input value 1`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down Expand Up @@ -580,6 +586,7 @@ exports[`SearchBox treats its query prop as its input value 2`] = `
autoCorrect="off"
autoFocus={false}
className="ais-SearchBox__input"
maxLength="512"
onChange={[Function]}
placeholder="Search here…"
required={true}
Expand Down