fix: revert dependencies to devDependencies #1135
Conversation
|
Deploy preview for react-instantsearch ready! Built with commit 5ce1557 https://deploy-preview-1135--react-instantsearch.netlify.com |
|
why not move to peer dependency now? |
|
I'm not sure which version to set. I prefer to revert the changes and move on a proper |
| "react": "^16.2.0", | ||
| "react-dom": "^16.2.0", | ||
| "react-native": "^0.54.2" | ||
| "prop-types": "^15.5.10" |
There was a problem hiding this comment.
Are prop types used in production builds?
There was a problem hiding this comment.
we can't strip them out in the library itself, since that way they'd only be useful for ourselves. People would strip them out at their bundling, not our I think
There was a problem hiding this comment.
In production build they are still present yes. But they are are used only in development. You can strip them with a babel plugin as @Haroenv suggest.
Summary
In the move to workspaces I accidentally move React as dependencies. It means that when you install React InstantSearch you also install React, React DOM & React Native. This PR revert this change, in a next version we should add those dependencies as peer.