fix(highlight): wrong parsing between client and server

[mthuret]

See #168

The Server-side html is rendered perfectly but then when rendered on the client using the resultsState props, results are containing the server old timestamp and <Highlight> the new client one. The <Highlight/> component then doesn't see any highlighted values and that's why we can see the little glitch.

For now, the solution is to remove the timestamp when dealing with highlighting tags.

[Haroenv]

Although @vvo said that the timestamp is against an attack vector, I think it's fine not to have it here.

[algobot]

Deploy preview ready!

Built with commit d190ba6

https://deploy-preview-183--react-instantsearch.netlify.com

[Haroenv]

I think this is a breaking change though, you could do s/<ais-highlight-\d{6}/>/<em>/g, and this would break it, no?

[mthuret]

@Haroenv => for people using regex and setDangerousHtml (for parsing arrays for instance), yes. Will document that in the migration guide when releasing. Hopefully this shouldn't be done by too many people.

[Haroenv]

In Yarn I imported the highlightTags module, so it should be safe to upgrade, I think this methods is the most used, so LGTM, other info was internal, so I think it's safe

[mthuret]

@Haroenv Is it because you need arrays support? We should be careful if we move the file then.

[Haroenv]

yes, for arrays I import highlightTags from 'react-instantsearch/src/core/highlightTags';, which will still work after this change

[vvo]

Also if people were importing and using stuff that is not documented this is not a breaking change I believe. This was not public API.