Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

refactor(InstantSearch): migrate life cycles #2349

Merged
merged 57 commits into from
Jun 17, 2019
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
06efa75
feat(client): remove algoliaClient alias
Haroenv Apr 15, 2019
0012284
chore(error): remove duplicate colon
Haroenv Apr 17, 2019
6deac03
docs(examples): use searchClient everywhere
Haroenv Apr 17, 2019
f0a0593
feat(searchClient): remove other options
Haroenv Apr 17, 2019
7677f02
adds back user agent tests & remove defaultAlgoliaClient
Haroenv Apr 17, 2019
7e81f7f
remove algoliasearch from dependencies
Haroenv Apr 17, 2019
0ec315f
remove algoliasearch usage
Haroenv Apr 17, 2019
0453b9d
chore: update max size
Haroenv Apr 17, 2019
4953745
refactor(root): remove createIndex & createInstantSearch
Haroenv Apr 17, 2019
8787dd8
add default state to Index
Haroenv Apr 18, 2019
3029b5f
fix tests
Haroenv Apr 18, 2019
ae5586d
remove useless types
Haroenv Apr 18, 2019
b1de630
changes to make tests pass again
Haroenv Apr 18, 2019
bb5fc85
move addAlgoliaAgent
Haroenv Apr 18, 2019
5f73bd3
temp: breaks everything
Haroenv Apr 19, 2019
2f250ec
make tests pass
Haroenv Apr 19, 2019
f43fb26
remove constructor
Haroenv Apr 19, 2019
edb5463
fix(propTypes): more strict searchClient type
Haroenv May 22, 2019
38f7c81
chore(examples): add algoliasearch as dependency
Haroenv May 22, 2019
18e4549
chore(stories): memoize search client
Haroenv May 22, 2019
6cae753
chore: update proptype
Haroenv May 22, 2019
0f22dfe
refactor(root): remove createIndex & createInstantSearch
Haroenv Apr 17, 2019
25aa42b
add default state to Index
Haroenv Apr 18, 2019
70a01c5
fix tests
Haroenv Apr 18, 2019
6a4e4ff
remove useless types
Haroenv Apr 18, 2019
60d41b9
changes to make tests pass again
Haroenv Apr 18, 2019
e77cd02
move addAlgoliaAgent
Haroenv Apr 18, 2019
a8015cb
Merge branch 'refactor/factory' into refactor/instantsearch-lc
Haroenv May 22, 2019
a95b47e
chore: update size
Haroenv May 22, 2019
f3b3d5b
Merge branch 'refactor/factory' into refactor/instantsearch-lc
Haroenv May 22, 2019
1810178
refactor(root): remove createIndex & createInstantSearch
Haroenv Apr 17, 2019
67497be
Merge branch 'refactor/factory' into refactor/instantsearch-lc
Haroenv May 23, 2019
5fd207f
test: update tests
Haroenv May 24, 2019
3dc85cf
refactor(root): move Index and InstantSearch to widgets
yannickcr Jun 4, 2019
4151ebb
refactor(root): remove addAlgoliaAgents export
yannickcr Jun 4, 2019
b95c15a
refactor(root): update Index documentation
yannickcr Jun 4, 2019
c49aeb2
refactor(root): init multiIndexContext using indexContext from state
yannickcr Jun 4, 2019
b701487
refactor(root): add comment in user agents test
yannickcr Jun 5, 2019
d4f9b3d
update enzyme
yannickcr Jun 5, 2019
c5ef054
move isControlled check in cDU
yannickcr Jun 5, 2019
c01703b
move updateIndex and updateClient in cDU
yannickcr Jun 5, 2019
61f7cd4
do not clear cache if refresh was already true
yannickcr Jun 5, 2019
61e1ecd
remove check in updateClient
yannickcr Jun 5, 2019
eedef1e
remove refreshValue
yannickcr Jun 5, 2019
574de2b
refactor(root): remove unused InstantSearch component
yannickcr Jun 5, 2019
77e31d0
Export InstantSearch from react-instantsearch-core
yannickcr Jun 12, 2019
cdef88c
Remove isControlled from state
yannickcr Jun 12, 2019
39b4d96
Add test for refresh
yannickcr Jun 12, 2019
192b63e
Remove extraneous check
yannickcr Jun 12, 2019
4a8db0b
Merge branch 'refactor/factory' into refactor/instantsearch-lc
yannickcr Jun 12, 2019
650a227
Merge branch 'v6' into refactor/factory
yannickcr Jun 14, 2019
56242d7
Merge branch 'refactor/factory' into refactor/instantsearch-lc
yannickcr Jun 14, 2019
e370ff8
Merge branch 'v6' into refactor/factory
yannickcr Jun 17, 2019
738aecb
Fix comment
yannickcr Jun 17, 2019
0088c41
Update bundlesize
yannickcr Jun 17, 2019
897b370
Merge branch 'refactor/factory' into refactor/instantsearch-lc
yannickcr Jun 17, 2019
0ab7249
Merge branch 'v6' into refactor/instantsearch-lc
yannickcr Jun 17, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,11 @@ class InstantSearch extends Component<Props, State> {
);
}

if (this.props.refresh) {
/*
* Clear cache when `refresh` changes to `true`.
* Prevents users to always clear the cache on render if they forget to revert it to `false`.
*/
if (this.props.refresh !== prevProps.refresh && this.props.refresh) {
samouss marked this conversation as resolved.
Show resolved Hide resolved
this.aisManager.clearCache();
}

Expand Down