This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 386
feat(insights): add getInsightsAnonymousUserToken helper #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrugg
force-pushed
the
feats/ease-insights-integration-3
branch
from
January 7, 2020 16:37
da11062
to
1e09a4c
Compare
ghost
requested review from
eunjae-lee and
Haroenv
and removed request for
a team
January 9, 2020 16:01
Haroenv
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, same as InstantSearch.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we still want to maintain the react-instantsearch
package, we might want to export the helper in this file too.
packages/react-instantsearch-dom/src/core/__tests__/getInsightsAnonymousUserToken.ts
Outdated
Show resolved
Hide resolved
…sAnonymousUserToken.ts Co-Authored-By: François Chalifour <francoischalifour@users.noreply.github.com>
Good point! done here fd10690 |
francoischalifour
added a commit
that referenced
this pull request
Jan 20, 2020
# [6.2.0](v6.1.0...v6.2.0) (2020-01-20) ### Bug Fixes * **deps:** update dependency algoliasearch to v3.35.1 ([#2802](#2802)) ([cfb91f0](cfb91f0)) * **widgets:** rename `ExperimentalConfigureRelatedItems` compon… ([#2891](#2891)) ([b910df2](b910df2)) ### Features * **insights:** add getInsightsAnonymousUserToken helper ([#2887](#2887)) ([b5fe4f7](b5fe4f7)) * **widgets:** introduce `ConfigureRelatedItems` as experimental ([#2880](#2880)) ([923cd43](923cd43))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds getInsightsAnonymousUserToken to
react-instantsearch-dom
.Related RFC: https://github.com/algolia/instantsearch-rfcs/pull/27