This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(MultiIndex): Trigger new search when <Index> props are updated
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 99bea20 |
vvo
changed the title
<Index> props are updated
Haroenv
approved these changes
Sep 12, 2017
vvo
approved these changes
Sep 12, 2017
| this.unregisterWidget = widgetsManager.registerWidget({ | ||
| getSearchParameters: searchParameters => | ||
| this.getSearchParameters(searchParameters, this.props), | ||
| multiIndexContext: { |
There was a problem hiding this comment.
Could we also have solved it by making multiIndexContext a function rather than a statically computed object?
Just being curious
There was a problem hiding this comment.
What this function would have return?
There was a problem hiding this comment.
The updated indexName rather than the statically computed one. But your solution works and is more obvious: when registering a widget, you pass it as a whole
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #310
Basically until now you couldn't have dynamic
<Index>.I think I also fix a bug with MultiIndex and SSR (a way to express multi index wasn't taken into account) with this PR.
What are the big changes here: the widget manager store the whole component instead of explicitly choose at constructor time.