This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
[Bugfix] Properly update search query when using browser navigation #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 9421389 |
This example properly updates the browser history on changes, but if you navigate using the browser back and next buttons, the search query doesn't change to match. This addition of a `componentWillReceiveProps` lifecycle method fixes that issue.
samouss
added a commit
that referenced
this pull request
Nov 27, 2017
<a name="4.3.0-beta.0"></a> # [4.3.0-beta.0](v4.2.0...v4.3.0-beta.0) (2017-11-27) ### Bug Fixes * **babelrc:** add a key for each env development, production, es ([#547](#547)) ([fa9528d](fa9528d)) * **localizecount:** allow localized string for count in MenuSelect ([#657](#657)) ([67ebd34](67ebd34)) * **react-router-example:** Properly update search query when using browser navigation ([#604](#604)) ([9ee6600](9ee6600)) ### Features * **refreshcache:** add prop refresh to InstantSearch instance ([#619](#619)) ([19f6de0](19f6de0))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This example properly updates the browser history on changes, but if you navigate using the browser back and next buttons, the search query doesn't change to match. This addition of a
componentWillReceivePropslifecycle method fixes that issue.Result
Clone the example, run
yarn, thenyarn start. Verify that searching and filtering still work correctly, and that browser navigation and full reload both maintain the search state correctly.