This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix: track all index in the manager #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
force-pushed
the
fix/track-all-index-parameters
branch
from
f72bb7c to
dd6a0f6
Compare
|
Deploy preview ready! Built with commit 663504d |
|
LGTM! |
|
Yep why not! Because this story is more related to a test case rather than documentation. It makes sense to me. |
samouss
force-pushed
the
fix/track-all-index-parameters
branch
2 times, most recently
from
0ceb3b0 to
50a3dce
Compare
samouss
force-pushed
the
fix/track-all-index-parameters
branch
from
50a3dce to
663504d
Compare
samouss
added a commit
that referenced
this pull request
Dec 20, 2017
<a name="4.3.0"></a> * reset page with multi index ([#665](#665)) ([865b7dc](865b7dc)) * **SearchBox:** use hidden over style to hide loader ([#714](#714)) ([ed5eb77](ed5eb77)) * test recipes ([#740](#740)) ([de2cc37](de2cc37)) * track all index in the manager ([#660](#660)) ([793502b](793502b)) * loading indicator ([#544](#544)) ([189659e](189659e)) * **Highlight:** support array of strings ([#715](#715)) ([8e93c6a](8e93c6a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #636
We already track the index for the
sharedparameters, but not for themainparameters. This PR aims to fix this issue by tracking all the indices.Result
You can play with the example on Storybook.