This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix: pass maxFacetHits to SFFV #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouss
force-pushed
the
fix/show-more-limit
branch
from
c25eb46 to
da13a90
Compare
|
Deploy preview for react-instantsearch ready! Built with commit 54e348b |
samouss
force-pushed
the
fix/show-more-limit
branch
4 times, most recently
from
aec6b62 to
0c2c0ca
Compare
…ve access to the instance
…axFacetHits to SFFV
samouss
force-pushed
the
fix/show-more-limit
branch
from
0c2c0ca to
54e348b
Compare
samouss
added a commit
that referenced
this pull request
Jan 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #707
Inside the
RefinementList&Menuwe can search through the list of items. On the first render themaxValuesPerFacetis correctly set on theSearchParameters. But when you trigger a search from theSearchBoxthe limit provided to the widget is ignored and only the default one is applied (which is10). It can produce unexpected results like the one linked inside the issue. ThelimitMaxis set to30but when you search for some facets since the latter is ignored you only have 10 results which is equal to thelimitMinand so the button is disabled.In the following example I search for
<space>so all the results are retrieve until the limit (15).Before:
After: