Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceMap decoder tests #199

Merged
merged 24 commits into from
Jul 13, 2022
Merged

SourceMap decoder tests #199

merged 24 commits into from
Jul 13, 2022

Conversation

barnjamin
Copy link
Contributor

No description provided.

@barnjamin barnjamin force-pushed the sourcemap branch 5 times, most recently from 8a13d31 to 5876f71 Compare June 24, 2022 15:42
@barnjamin barnjamin mentioned this pull request Jun 24, 2022
Closed
@barnjamin barnjamin marked this pull request as ready for review June 24, 2022 16:36
algochoi
algochoi reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge master into this branch (just to confirm we didn't change anything other than this test)

@barnjamin barnjamin requested a review from algochoi June 27, 2022 15:02
algochoi
algochoi approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

michaeldiamant
michaeldiamant approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barnjamin Thanks for working through multiple iterations to provide source map decoding parity! ☕

@barnjamin barnjamin merged commit be04852 into master Jul 13, 2022
@barnjamin barnjamin deleted the sourcemap branch July 13, 2022 13:21
@michaeldiamant michaeldiamant mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algochoi algochoi algochoi approved these changes

@michaeldiamant michaeldiamant michaeldiamant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barnjamin @michaeldiamant @algochoi