Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate AVM and TEAL versions in test comments #346

Conversation

jdtzmn
Copy link

@jdtzmn jdtzmn commented Jul 18, 2022

This PR adds additional version consolidation changes to the existing TEAL/AVM language consolidation PR.

@@ -191,7 +191,7 @@ func TestCheckProgramV5(t *testing.T) {
}

func TestCheckProgramV6(t *testing.T) {
// check TEAL v6 opcodes
// check program v6 opcodes
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR: will it be necessary to add v7 program checks to the SDKs prior to the AVM version 7 release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdtzmn Good question - I think we'll need to make a pass after go-algorand exposes v7.

Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdtzmn Thanks for the help here - merging!

@michaeldiamant michaeldiamant merged commit 557ae3f into algorand:avm_version_consolidation Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants