reject non-canonical

algorand · Aug 8, 2024 · 8701866 · 8701866
1 parent 6a6f276
commit 8701866
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/data/txHandler.go b/data/txHandler.go
@@ -808,17 +808,18 @@ func (handler *TxHandler) validateIncomingTxMessage(rawmsg network.IncomingMessa
 	if drop {
 		return network.OutgoingMessage{Action: network.Ignore}
 	}
+
+	if handler.incomingTxGroupAppRateLimit(unverifiedTxGroup, rawmsg.Sender) {
+		return network.OutgoingMessage{Action: network.Ignore}
+	}
+
 	if reencoded == nil {
 		reencoded = reencode(unverifiedTxGroup)
 	}
 
 	if !bytes.Equal(rawmsg.Data, reencoded) {
-		// ignore non-canonically encoded messages
-		return network.OutgoingMessage{Action: network.Ignore}
-	}
-
-	if handler.incomingTxGroupAppRateLimit(unverifiedTxGroup, rawmsg.Sender) {
-		return network.OutgoingMessage{Action: network.Ignore}
+		// reject non-canonically encoded messages
+		return network.OutgoingMessage{Action: network.Disconnect}
 	}
 
 	// apply backlog worker logic