Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: add container build #4927

Merged
merged 34 commits into from
Jan 6, 2023
Merged

CICD: add container build #4927

merged 34 commits into from
Jan 6, 2023

Conversation

algolucky
Copy link
Contributor

@algolucky algolucky commented Dec 20, 2022

Summary

Adds a GitHub Actions container workflow and other updates.

Supported Platforms

  • linux/amd64
  • linux/arm64

Image Sizes

image

Tags

  • feature/*, rel/*, and master branches (e.g. feature/testing -> feature-testing)
  • tag (e.g. v3.13.1-stable)
  • long commit SHA (e.g. f06c481)

Notable Changes

  • removed the use of ./scripts/dev_install.sh.
    • coming after make build this was another build.
    • this forced the CHANNEL to always be dev even when building other branches like rel/stable.
    • this also removed the creation of dataTemplate. the functionality was replaced by instead copying config.json.example to the correct location in run.sh in start_new_public_network
  • switched builder to use ubuntu:18.04 instead of golang:$GO_VERSION-slim
  • creates and uses the algorand user inside the container.
    • moved the COPY of files from builder to after user creation and used --chown flag in COPY statement.
  • removed python and git-core from the installation step in the builder.
  • added --install-no-recommends to all apt-get install -y invocations.
  • consolidated EXPOSE and ENV statements when possible.
  • set GOPATH in builder image ENV.
  • removed default for CHANNEL build argument.
  • added a step in install.sh to remove artifacts that are not required.

Test Plan

  • internal dog fooding
  • sandbox (TBD)

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #4927 (d49a8bb) into master (5979c09) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4927      +/-   ##
==========================================
- Coverage   53.54%   53.52%   -0.03%     
==========================================
  Files         431      431              
  Lines       53533    53533              
==========================================
- Hits        28662    28651      -11     
- Misses      22644    22656      +12     
+ Partials     2227     2226       -1     
Impacted Files Coverage Δ
ledger/tracker.go 74.26% <0.00%> (-3.80%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
ledger/acctupdates.go 69.24% <0.00%> (-0.25%) ⬇️
network/wsNetwork.go 64.74% <0.00%> (ø)
ledger/testing/randomAccounts.go 56.61% <0.00%> (ø)
catchup/service.go 70.53% <0.00%> (+0.72%) ⬆️
ledger/catchpointtracker.go 58.49% <0.00%> (+0.79%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algolucky algolucky self-assigned this Dec 20, 2022
@algolucky algolucky requested review from winder and a team December 20, 2022 23:14
algobarb
algobarb previously approved these changes Jan 4, 2023
algojack
algojack previously approved these changes Jan 4, 2023
Copy link
Contributor

@algojack algojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@algolucky algolucky dismissed stale reviews from algojack and algobarb via d49a8bb January 4, 2023 20:25
@algolucky algolucky requested review from algojack and algobarb January 4, 2023 20:26
Copy link
Contributor

@excalq excalq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great. Mainly just had some questions / minor suggestions.

@algolucky
Copy link
Contributor Author

thank you @winder for the suggestions, I'd like to address your comments in a fast-follow PR. they are all valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants