-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CICD: add container build #4927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4927 +/- ##
==========================================
- Coverage 53.54% 53.52% -0.03%
==========================================
Files 431 431
Lines 53533 53533
==========================================
- Hits 28662 28651 -11
- Misses 22644 22656 +12
+ Partials 2227 2226 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great. Mainly just had some questions / minor suggestions.
thank you @winder for the suggestions, I'd like to address your comments in a fast-follow PR. they are all valid. |
Summary
Adds a GitHub Actions container workflow and other updates.
Supported Platforms
Image Sizes
Tags
Notable Changes
./scripts/dev_install.sh
.make build
this was another build.dev
even when building other branches likerel/stable
.dataTemplate
. the functionality was replaced by instead copying config.json.example to the correct location inrun.sh
instart_new_public_network
ubuntu:18.04
instead ofgolang:$GO_VERSION-slim
algorand
user inside the container.python
andgit-core
from the installation step in the builder.--install-no-recommends
to allapt-get install -y
invocations.install.sh
to remove artifacts that are not required.Test Plan