Ledger: bulletin leaking waiters fix #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almog-t
changed the title
almog-t
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4962 +/- ##
==========================================
- Coverage 53.74% 53.70% -0.04%
==========================================
Files 433 433
Lines 54050 54051 +1
==========================================
- Hits 29049 29028 -21
- Misses 22759 22777 +18
- Partials 2242 2246 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@almog-t is it possible to write a test for this? |
algorandskiy
approved these changes
Jan 4, 2023
winder
pushed a commit
to winder/go-algorand
that referenced
this pull request
Jan 18, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes potential leak of ledger waiters.
Test Plan
Unit test that triggers leak in ledger_test.go.