avm-abi: Update functions migrated to avm-abi library #4979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlgoStephenAkiki
force-pushed
the
1328-remove-logic
branch
2 times, most recently
from
fd7e913 to
bf6d8a7
Compare
AlgoStephenAkiki
force-pushed
the
1328-remove-logic
branch
from
bf6d8a7 to
1fb45ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #4979 +/- ##
==========================================
- Coverage 53.68% 53.65% -0.04%
==========================================
Files 432 431 -1
Lines 54068 53998 -70
==========================================
- Hits 29029 28975 -54
+ Misses 22793 22784 -9
+ Partials 2246 2239 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Converted to Draft to prevent accidental merge before AVM-ABI release |
winder
reviewed
Jan 13, 2023
winder
reviewed
Jan 13, 2023
winder
reviewed
Jan 13, 2023
winder
suggested changes
Jan 13, 2023
winder
changed the title
winder
reviewed
Jan 18, 2023
go.mod
Outdated
| @@ -39,6 +38,7 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| github.com/algorand/avm-abi v0.2.0 // indirect | |||
There was a problem hiding this comment.
Not sure. I added this via go get but updated the mod file manually to be a direct require.
There was a problem hiding this comment.
I believe you can run go mod tidy to have go update the dependencies to match their usage in the codebase. I'd recommend still running it locally, since it might reorder the dependencies
winder
previously approved these changes
Jan 18, 2023
winder
requested review from
bbroder-algo
and removed request for
michaeldiamant
jasonpaulos
reviewed
Jan 18, 2023
AlgoStephenAkiki
force-pushed
the
1328-remove-logic
branch
from
d056257 to
acaa2d1
Compare
jasonpaulos
approved these changes
Jan 18, 2023
winder
approved these changes
Jan 19, 2023
algorandskiy
added a commit
to algorandskiy/go-algorand
that referenced
this pull request
Jan 19, 2023
algorandskiy
added a commit
that referenced
this pull request
Jan 19, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several functions have been migrated to the avm-abi library. This pull request updates the code to use the functions in their new location.
Test Plan
Existing regression tests.