network: new default gossip fanout setting for relays #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssip fanout when nodes are configured as relays.
Codecov Report
@@ Coverage Diff @@
## master #5005 +/- ##
==========================================
+ Coverage 53.63% 53.65% +0.01%
==========================================
Files 432 432
Lines 54057 54059 +2
==========================================
+ Hits 28996 29004 +8
+ Misses 22812 22811 -1
+ Partials 2249 2244 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…ding to codegen/expose into local_defaults.go
|
|
||
| // If gossip fanout has not been explicitly overridden, use defaultRelayGossipFanout | ||
| // rather then the default gossip fanout setting from defaultLocal | ||
| if source.GossipFanout == defaultLocal.GossipFanout { |
There was a problem hiding this comment.
does this prevent relays from explicitly overriding this fanout change back the current local default value of 4?
There was a problem hiding this comment.
Yes, though they could set 3 or 5.
algorandskiy
changed the title
algorandskiy
approved these changes
Jan 19, 2023
|
This should go with #5018 |
cce
approved these changes
Jan 20, 2023
This was referenced Jan 23, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce override of default gossip fanout to a new default relay gossip fanout when nodes are configured as relays.
Test Plan
Configured node with netAddress and ran locally with and without gossipFanout overridden.