Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix warnings #5047

Merged
merged 2 commits into from
Jan 24, 2023
Merged

lint: fix warnings #5047

merged 2 commits into from
Jan 24, 2023

Conversation

cce
Copy link
Contributor

@cce cce commented Jan 23, 2023

Summary

@algojack got the warning-level linters working again in #5006 which missed a few warnings while it was broken. This fixes those warnings.

Test Plan

Tests should pass, and warning-level linter output should be empty now.

algojack
algojack previously approved these changes Jan 23, 2023
Copy link
Contributor

@algojack algojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@algojack algojack assigned algojack and cce and unassigned algojack Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #5047 (9470ca2) into master (7e37e00) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5047   +/-   ##
=======================================
  Coverage   53.48%   53.48%           
=======================================
  Files         429      429           
  Lines       54043    54033   -10     
=======================================
- Hits        28904    28899    -5     
+ Misses      22894    22887    -7     
- Partials     2245     2247    +2     
Impacted Files Coverage Δ
cmd/tealdbg/dryrunRequest.go 65.90% <ø> (+12.20%) ⬆️
shared/pingpong/pingpong.go 0.00% <ø> (ø)
util/rateLimit.go 82.35% <ø> (ø)
util/tcpinfo_linux.go 0.00% <ø> (ø)
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
ledger/acctupdates.go 68.75% <0.00%> (-0.73%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (-0.62%) ⬇️
network/wsNetwork.go 64.92% <0.00%> (ø)
catchup/service.go 69.80% <0.00%> (+0.72%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cce cce requested a review from jdtzmn January 24, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants