Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVM: Fix opBytesLt for len(rhs) < len(lhs) #5051

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

jannotti
Copy link
Contributor

Added test for old failing case.

Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a right implementation... my bad for didn't catching the bytes.Compare behavior...

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #5051 (bfdd36a) into master (2594c32) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5051      +/-   ##
==========================================
+ Coverage   53.55%   53.58%   +0.02%     
==========================================
  Files         430      430              
  Lines       54085    54091       +6     
==========================================
+ Hits        28966    28984      +18     
+ Misses      22873    22864       -9     
+ Partials     2246     2243       -3     
Impacted Files Coverage Δ
data/transactions/logic/eval.go 90.48% <100.00%> (+0.01%) ⬆️
ledger/tracker.go 74.26% <0.00%> (-0.85%) ⬇️
ledger/acctonline.go 78.64% <0.00%> (-0.53%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (ø)
ledger/acctupdates.go 69.24% <0.00%> (+0.24%) ⬆️
catchup/service.go 69.80% <0.00%> (+0.48%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
agreement/proposalManager.go 98.03% <0.00%> (+1.96%) ⬆️
agreement/cryptoVerifier.go 69.71% <0.00%> (+2.11%) ⬆️
crypto/merkletrie/trie.go 68.61% <0.00%> (+2.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants