CI: upgrade test_nightly infra to large #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please trigger nightly build to confirm |
Codecov Report
@@ Coverage Diff @@
## master #5054 +/- ##
==========================================
- Coverage 53.57% 53.57% -0.01%
==========================================
Files 430 430
Lines 54091 54091
==========================================
- Hits 28979 28977 -2
Misses 22868 22868
- Partials 2244 2246 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
After more testing, we should revert #5053 and enable this if we think it makes sense. |
|
the checks don't show correctly in github due to me rerunning the tests manually and cancelling the ones that are not needed. Please ignore circleci tests checkmarks in github, they passed as of this commit. |
onetechnical
approved these changes
Feb 15, 2023
|
#5053 may have some flakiness to it outside of this instance sizing, so we should not revert it. That said, a bump in this instance size would be welcome to reduce time and reduce other flakiness. |
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This increases the test_nightly build resource class from medium (2 cores) to large (4 cores) as an alternative to #5053.
Test Plan
Existing tests should pass, nightly tests should also perform better.