-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
goal: allow for relative dataDir via -d cmd option #5067
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5067 +/- ##
==========================================
+ Coverage 53.56% 53.58% +0.02%
==========================================
Files 430 430
Lines 54091 54094 +3
==========================================
+ Hits 28972 28985 +13
+ Misses 22873 22860 -13
- Partials 2246 2249 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@algorandskiy , the Ci complains...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make resolveDataDir
a function taking dirs as its argument, and update cmd/algocfg/datadir.go
as well, and probably move it to cmd/utils
. But this also LGTM
I did not notice the code-duplication, there are even more Would prefer to handle them in a separate follow-up issue/PR (see #5068).
Ty! (btw: fascinating fast PR processing!) |
closes #589 |
@algorandskiy , somehow the github auto-close-issue did not trigger, still open: #589 |
Post Merge Complaint
[COMPLAINT] Is the Algorand Inc. aware of the heavily dysfunctional Algorand Foundation?
Summary
Allow relative data-dir, as described within #589
Test Plan
existent tests pass, added some more tests
go test -v ./cmd/goal
Follow-up
#5073