algod: split SetFdSoftLimit calls for relay and non-relay nodes #5070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace shared "tempdir" by t.TempDir * Make them parallel * Make test naming consistent
Codecov Report
@@ Coverage Diff @@
## master #5070 +/- ##
==========================================
- Coverage 53.58% 53.56% -0.02%
==========================================
Files 430 430
Lines 54088 54131 +43
==========================================
+ Hits 28984 28997 +13
- Misses 22860 22889 +29
- Partials 2244 2245 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlgoAxel
reviewed
Jan 31, 2023
cce
reviewed
Jan 31, 2023
cce
reviewed
Jan 31, 2023
brianolson
previously approved these changes
Jan 31, 2023
cce
reviewed
Jan 31, 2023
cce
reviewed
Feb 1, 2023
cce
reviewed
Feb 1, 2023
cce
reviewed
Feb 1, 2023
algorandskiy
force-pushed
the
pavel/setrlimit-non-relay
branch
from
3e44bdd to
8d2cf28
Compare
cce
previously approved these changes
Feb 1, 2023
algorandskiy
force-pushed
the
pavel/setrlimit-non-relay
branch
from
8d2cf28 to
7215a3e
Compare
cce
approved these changes
Feb 1, 2023
|
the adjustment logic looks good only remains to be seen that the windows build still operates as expected |
bbroder-algo
approved these changes
Feb 1, 2023
algorandskiy
changed the title
gmalouf
approved these changes
Feb 1, 2023
algolucky
pushed a commit
to algolucky/go-algorand
that referenced
this pull request
Feb 2, 2023
This was referenced Mar 10, 2023
cce
reviewed
Apr 6, 2023
| } | ||
| err = util.SetFdSoftLimit(fdRequired) | ||
| if err != nil { | ||
| return fmt.Errorf("Initialize() err: %w", err) | ||
| } | ||
| if cfg.IsGossipServer() { | ||
| var ot basics.OverflowTracker | ||
| fdRequired := ot.Add(fdRequired, uint64(cfg.IncomingConnectionsLimit)) |
There was a problem hiding this comment.
this shadows fdRequired declared above (but is OK since the original is not used later)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
algod sets RLIMIT_NOFILE to max possible value on startup. This might result the node failure on startup especially if it is a non-relaying node and does not need to listen for thousands of incoming connections.
Additionally enhanced config test since I opened the file:
Test Plan
New test for
IsGossipServerconfig helper. Existing tests for everything else.