Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Incorrect KvDelta in StateDeltaToLedgerDelta #5084

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

shiqizng
Copy link
Contributor

resolves #5083

@shiqizng shiqizng self-assigned this Jan 31, 2023
@shiqizng shiqizng changed the title fix: Incorrect KvDelta in StateDeltaToLedgerDelta Bug-Fix: Incorrect KvDelta in StateDeltaToLedgerDelta Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #5084 (ca8d24f) into master (c8b5deb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5084      +/-   ##
==========================================
+ Coverage   53.51%   53.53%   +0.02%     
==========================================
  Files         431      431              
  Lines       54138    54139       +1     
==========================================
+ Hits        28972    28984      +12     
+ Misses      22911    22903       -8     
+ Partials     2255     2252       -3     
Impacted Files Coverage Δ
daemon/algod/api/server/v2/delta.go 72.00% <100.00%> (+0.28%) ⬆️
ledger/tracker.go 75.10% <0.00%> (-2.96%) ⬇️
catchup/service.go 68.59% <0.00%> (-1.21%) ⬇️
cmd/tealdbg/debugger.go 71.65% <0.00%> (-0.79%) ⬇️
ledger/testing/randomAccounts.go 56.26% <0.00%> (ø)
network/wsNetwork.go 65.22% <0.00%> (+0.18%) ⬆️
ledger/acctupdates.go 69.60% <0.00%> (+0.36%) ⬆️
ledger/acctonline.go 78.64% <0.00%> (+0.52%) ⬆️
crypto/merkletrie/node.go 93.48% <0.00%> (+1.86%) ⬆️
network/wsPeer.go 67.36% <0.00%> (+1.86%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder changed the title Bug-Fix: Incorrect KvDelta in StateDeltaToLedgerDelta API: Incorrect KvDelta in StateDeltaToLedgerDelta Feb 2, 2023
@winder winder merged commit e544fc8 into algorand:master Feb 2, 2023
@shiqizng shiqizng deleted the shiqi/fix branch April 3, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect KvDelta in StateDeltaToLedgerDelta
3 participants