Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Fix time since last block. #5113

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Feb 3, 2023

Summary

We started skipping the last round timestamp and synced since timestamp with a recent change.

Test Plan

New e2e test.

node/follower_node.go Show resolved Hide resolved
node/follower_node.go Show resolved Hide resolved
Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once your test passes.

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #5113 (5faa106) into master (6487b37) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5113      +/-   ##
==========================================
+ Coverage   53.42%   53.43%   +0.01%     
==========================================
  Files         431      431              
  Lines       54369    54381      +12     
==========================================
+ Hits        29046    29058      +12     
- Misses      23061    23066       +5     
+ Partials     2262     2257       -5     
Impacted Files Coverage Δ
node/follower_node.go 24.86% <0.00%> (-0.84%) ⬇️
node/node.go 4.10% <0.00%> (-0.04%) ⬇️
ledger/blockqueue.go 82.25% <0.00%> (-2.69%) ⬇️
ledger/testing/randomAccounts.go 55.65% <0.00%> (-0.62%) ⬇️
network/wsNetwork.go 64.98% <0.00%> (-0.19%) ⬇️
catchup/service.go 69.17% <0.00%> (+0.23%) ⬆️
ledger/acctonline.go 79.16% <0.00%> (+0.52%) ⬆️
ledger/acctupdates.go 69.72% <0.00%> (+0.72%) ⬆️
ledger/catchpointtracker.go 58.69% <0.00%> (+0.78%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review February 6, 2023 14:15
Copy link
Contributor

@mciccarello mciccarello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

Copy link
Contributor

@algojack algojack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing it.

@winder winder merged commit 5511cf3 into algorand:master Feb 6, 2023
@winder winder deleted the will/time-since-last-block branch February 6, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants