-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: Fix time since last block. #5113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once your test passes.
Codecov Report
@@ Coverage Diff @@
## master #5113 +/- ##
==========================================
+ Coverage 53.42% 53.43% +0.01%
==========================================
Files 431 431
Lines 54369 54381 +12
==========================================
+ Hits 29046 29058 +12
- Misses 23061 23066 +5
+ Partials 2262 2257 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for fixing it.
Summary
We started skipping the last round timestamp and synced since timestamp with a recent change.
Test Plan
New e2e test.