-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add follower node documentation. #5181
Conversation
f5ec400
to
14a1eef
Compare
docs/follower_node.md
Outdated
## Usage | ||
|
||
New public endpoints are available to control the node: | ||
* `GET /v2/ledger/sync` - fetch the current minimum sync round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a "sync round"? You introduce the term without explaining, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still confusing to me. "... round the node is synchronized with" does that mean the round the node is caught up to? I'm confused because what is then the "minimum sync round"?
Maybe this deserves a little higher level explanation right above where you lay out the endpoints?
docs/follower_node.md
Outdated
## Usage | ||
|
||
New public endpoints are available to control the node: | ||
* `GET /v2/ledger/sync` - fetch the current minimum sync round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still confusing to me. "... round the node is synchronized with" does that mean the round the node is caught up to? I'm confused because what is then the "minimum sync round"?
Maybe this deserves a little higher level explanation right above where you lay out the endpoints?
Codecov Report
@@ Coverage Diff @@
## master #5181 +/- ##
==========================================
- Coverage 53.60% 53.58% -0.03%
==========================================
Files 439 439
Lines 54934 54934
==========================================
- Hits 29447 29436 -11
- Misses 23208 23210 +2
- Partials 2279 2288 +9 see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary
Some general information about follower nodes.
Test Plan
N/A