Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add follower node documentation. #5181

Merged
merged 4 commits into from
Mar 10, 2023

Conversation

winder
Copy link
Contributor

@winder winder commented Mar 8, 2023

Summary

Some general information about follower nodes.

Test Plan

N/A

@winder winder marked this pull request as ready for review March 8, 2023 16:22
Eric-Warehime
Eric-Warehime previously approved these changes Mar 8, 2023
docs/follower_node.md Outdated Show resolved Hide resolved
## Usage

New public endpoints are available to control the node:
* `GET /v2/ledger/sync` - fetch the current minimum sync round.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is a "sync round"? You introduce the term without explaining, I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still confusing to me. "... round the node is synchronized with" does that mean the round the node is caught up to? I'm confused because what is then the "minimum sync round"?

Maybe this deserves a little higher level explanation right above where you lay out the endpoints?

docs/follower_node.md Outdated Show resolved Hide resolved
docs/follower_node.md Outdated Show resolved Hide resolved
## Usage

New public endpoints are available to control the node:
* `GET /v2/ledger/sync` - fetch the current minimum sync round.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still confusing to me. "... round the node is synchronized with" does that mean the round the node is caught up to? I'm confused because what is then the "minimum sync round"?

Maybe this deserves a little higher level explanation right above where you lay out the endpoints?

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #5181 (0eb2168) into master (9220f7b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5181      +/-   ##
==========================================
- Coverage   53.60%   53.58%   -0.03%     
==========================================
  Files         439      439              
  Lines       54934    54934              
==========================================
- Hits        29447    29436      -11     
- Misses      23208    23210       +2     
- Partials     2279     2288       +9     

see 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@algoanne algoanne self-requested a review March 9, 2023 20:40
@winder winder merged commit a353691 into algorand:master Mar 10, 2023
@winder winder deleted the will/follower-doc branch March 10, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants