util/s3: improve patch number capacity in version comparison #5224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
reviewed
Mar 22, 2023
cmd/updater/version_test.go
Outdated
| testValidVersion(t, "algonode_update_0.1.0.log", uint64(0x01000000)) | ||
| testValidVersion(t, "algo_update_0.1.0", uint64(0x01000000)) | ||
| testValidVersion(t, "algo_update_65535.1.0", uint64(0x00FFFF000001000000)) | ||
| testValidVersion(t, "algo_update_65535.65535.65535", uint64(0x00FFFF00FFFF00FFFF)) |
There was a problem hiding this comment.
May as well add the test
Suggested change
| testValidVersion(t, "algo_update_65535.65535.65535", uint64(0x00FFFF00FFFF00FFFF)) | |
| testValidVersion(t, "algo_update_65535.65535.65535", uint64(0x00FFFF00FFFF00FFFF)) | |
| testValidVersion(t, "algo_update_16777215.16777215.16777215", uint64(0xFFFFFFFFFFFFFFFFFF)) |
There was a problem hiding this comment.
this number exceeds max uint64
maybe allocate 24bits for the patch and 16+16 for major/minor?
There was a problem hiding this comment.
16/16/24 seems like a good option.
winder
reviewed
Mar 22, 2023
winder
previously approved these changes
Mar 22, 2023
Codecov Report
@@ Coverage Diff @@
## master #5224 +/- ##
==========================================
+ Coverage 52.94% 53.56% +0.62%
==========================================
Files 441 441
Lines 55098 55099 +1
==========================================
+ Hits 29171 29514 +343
+ Misses 23576 23298 -278
+ Partials 2351 2287 -64
... and 48 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algobarb
approved these changes
Mar 22, 2023
winder
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Local builds could produce packages with higher than build number than the comparator in
updatercan handle.This affects both updater and nodecfg.
Test Plan
Added unit test