Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: Check MaxAcctLookback in tracker. #5300

Merged
merged 1 commit into from
Apr 13, 2023
Merged

ledger: Check MaxAcctLookback in tracker. #5300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ledger/tracker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,8 +727,8 @@ func (tr *trackerRegistry) replay(l ledgerForTracker) (err error) {
roundsBehind = blk.Round() - tr.dbRound
tr.mu.RUnlock()

// are we too far behind ? ( taking into consideration the catchpoint writing, which can stall the writing for quite a bit )
if roundsBehind > initializeCachesRoundFlushInterval+basics.Round(catchpointInterval) {
// are we farther behind than we need to be? Consider: catchpoint interval, flush interval and max acct lookback.
if roundsBehind > basics.Round(maxAcctLookback) && roundsBehind > initializeCachesRoundFlushInterval+basics.Round(catchpointInterval) {
// we're unable to persist changes. This is unexpected, but there is no point in keep trying batching additional changes since any further changes
// would just accumulate in memory.
close(blockEvalFailed)
Expand Down