Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update agreement README with committableEvent #5317

Merged
merged 1 commit into from Apr 20, 2023
Merged

docs: update agreement README with committableEvent #5317

merged 1 commit into from Apr 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2023

the mentioned proposalCommittableEvent does not exist in this form within the source code.

The correct event is committableEvent

type committableEvent struct {
// Proposal is set to be the proposal-value which is committable.
Proposal proposalValue
// the proposal-vote that authenticated the payload (if one exists)
Vote vote
}

Copy link
Contributor

@bbroder-algo bbroder-algo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

@winder winder changed the title docs: mention committableEvent (as in source-code) docs: update agreement README with committableEvent Apr 20, 2023
@winder winder merged commit cae1b5b into algorand:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants