tools: block generator data reporting #5339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiqizng
changed the title
tzaffi
reviewed
Apr 26, 2023
| @@ -0,0 +1 @@ | |||
| datadog==0.45.0 | |||
There was a problem hiding this comment.
I don't like maintaining python deps/packages w/ requirements.txt files. For something small like this I think it's fine, but if we plan on having multiple scripts w/ different dependencies, shared modules, etc. we should think about having a proper python package.
tzaffi
approved these changes
Apr 27, 2023
Eric-Warehime
approved these changes
Apr 27, 2023
algochoi
reviewed
Apr 28, 2023
| @@ -0,0 +1,53 @@ | |||
| from datadog import initialize | |||
There was a problem hiding this comment.
nit: can combine below import
Suggested change
| from datadog import initialize | |
| from datadog import api, initialize |
winder
approved these changes
May 3, 2023
This was referenced May 9, 2023
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a script to send block TPS result from a block generator report to datadog.