goal: Make goal state schema optional #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5356 +/- ##
=======================================
Coverage 55.25% 55.25%
=======================================
Files 454 454
Lines 63723 63722 -1
=======================================
Hits 35208 35208
Misses 26122 26122
+ Partials 2393 2392 -1
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bbroder-algo
approved these changes
May 4, 2023
jannotti
approved these changes
May 4, 2023
This was referenced May 9, 2023
This was referenced May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up from #4946, this PR makes the goal app flags
--global-byteslices,--global-ints,--local-byteslices, and--local-intsoptional. Also errors earlier for invalid box names.Test Plan
Added
test/scripts/e2e_subs/goal-app-create-state-defaults.shto ensure that omitting the flags has the same effect as setting them to 0.Also modified existing tests to prefer omitting the state schema flags instead of setting them to 0.