api: blocks/{round}/logs endpoint

[joe-p]

Summary

This is a new endpoint to get all of the logs from all appcalls in a given block. This endpoint was created specifically due to the encoding issue with the current /blocks/{round} endpoint (#5807).

Test Plan

Tests cover the following scenarios:

• log in outer transaction
• log from inner transaction
• log from newly created application
• logs from multiple outer app calls

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 56.17%. Comparing base (5f81b7b) to head (267de9e).
Report is 1 commits behind head on master.

Files	Patch %	Lines
daemon/algod/api/server/v2/handlers.go	0.00%	35 Missing ⚠️
libgoal/libgoal.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5865      +/-   ##
==========================================
+ Coverage   52.42%   56.17%   +3.75%     
==========================================
  Files         482      482              
  Lines       67969    68009      +40     
==========================================
+ Hits        35630    38205    +2575     
+ Misses      29656    27210    -2446     
+ Partials     2683     2594      -89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joe-p]

I've verified the logs are returned properly via external testing here: https://github.com/joe-p/block-log-debug/blob/6daea7ad53b83366c75aaf3325c719bc6fbd0646/__test__/block-log-debug.test.ts#L12

I'll need to write the proper tests here but should be good to go.

Other things to consider:

1. Do we want query parameters to filter logs? I can imagine a prefix and appID filter would be useful.
2. I feel like we should probably have some sort of way to limit response size. I think the most reasonable approach is to add query parameters for start and maxResults parameter but this will only work if txn order is deterministic in the block. I would think it is but would like some confirmation.

[jannotti]

Since this returns, at most, the logs in one block, I don't think you need to add any filtering or limiting.

[joe-p]

Yeah true, we know the upper bound due to the block size limit. Keeping it as is is good with me then.

[jannotti]

A few small things you may or may not bother with.

[joe-p]

@jasonpaulos @jannotti I just added a fairly basic test in test/e2e-go/restAPI/other/appsRestAPI_test.go. Seemed like the most appropriate place for this to go but let me know what else is needed before this can be merged.

[jannotti]

I'm happy if we get some form of the description change I recommended. I want the response order to be defined.

[jasonpaulos]

+1 to being more explicit about the endpoint description, but other than that, this looks good

[gmalouf]

closes #5807