network: use network context for DNS operations in readFromSRV #5936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pending DNS operations might cause delay on node shutdown * Providing a cancellable context to underlying resolver would about operations that could stuck in timeout otherwise
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5936 +/- ##
==========================================
- Coverage 55.73% 55.71% -0.03%
==========================================
Files 487 487
Lines 68048 68048
==========================================
- Hits 37927 37911 -16
- Misses 27561 27572 +11
- Partials 2560 2565 +5 ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Feb 13, 2024
jasonpaulos
approved these changes
Feb 13, 2024
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Existing tests should pass.
I narrowed down the e2e_basic_start_stop.sh sporadic failures to
wsNetwork.meshThreadthat makes me think DNS lookup timeouts might be responsible for that.