Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix flakey incentive e2e tests #5986

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

jasonpaulos
Copy link
Contributor

Summary

Trying to make incentives tests less flakey.

Test Plan

Test change

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.19%. Comparing base (82f4cde) to head (33f55b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5986      +/-   ##
==========================================
+ Coverage   56.16%   56.19%   +0.02%     
==========================================
  Files         482      482              
  Lines       68027    68027              
==========================================
+ Hits        38209    38228      +19     
+ Misses      27224    27211      -13     
+ Partials     2594     2588       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonpaulos jasonpaulos requested a review from jannotti April 25, 2024 20:19
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these. We might also try lengthening the round times a bit. I shrunk them all the way down to time.Second/2. Maybe 3/4 or a full second would prevent us from playing whack-a-mole on spurious errors.

@gmalouf gmalouf merged commit d99c5c3 into algorand:master Apr 30, 2024
18 checks passed
@jasonpaulos jasonpaulos deleted the incentives-flakey-test-change branch April 30, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants