-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Fix flakey incentive e2e tests #5986
Tests: Fix flakey incentive e2e tests #5986
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5986 +/- ##
==========================================
+ Coverage 56.16% 56.19% +0.02%
==========================================
Files 482 482
Lines 68027 68027
==========================================
+ Hits 38209 38228 +19
+ Misses 27224 27211 -13
+ Partials 2594 2588 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with these. We might also try lengthening the round times a bit. I shrunk them all the way down to time.Second/2
. Maybe 3/4 or a full second would prevent us from playing whack-a-mole on spurious errors.
Summary
Trying to make incentives tests less flakey.
Test Plan
Test change