Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix flakey htlc test #6017

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

jasonpaulos
Copy link
Contributor

@jasonpaulos jasonpaulos commented Jun 6, 2024

Summary

Fix for flakey htlc test, which is comparing exact account balance. I believe sometimes rewards are applied, so it's off by a small amount. Fixed this by comparing to the minimum expected amount of algos.

Example of a failure: https://app.circleci.com/pipelines/github/algorand/go-algorand/18425/workflows/259ccdba-c6c1-4093-abd9-e0c59e22a0d3/jobs/272733

Test Plan

Existing tests should pass

@jasonpaulos jasonpaulos marked this pull request as ready for review June 6, 2024 19:58
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's reasonable, but maybe better to have the account go non-participating instead?

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.19%. Comparing base (8d228c0) to head (f3ab4c0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6017      +/-   ##
==========================================
- Coverage   55.89%   55.19%   -0.71%     
==========================================
  Files         481      481              
  Lines       68357    68357              
==========================================
- Hits        38210    37728     -482     
- Misses      27551    28002     +451     
- Partials     2596     2627      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit 0c02f9b into algorand:master Jun 7, 2024
20 checks passed
@jasonpaulos jasonpaulos deleted the fix-flakey-htlc-test branch June 10, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants