Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catchup: skip logging err for catchup cancellation #6053

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

urtho
Copy link
Contributor

@urtho urtho commented Jul 6, 2024

Should logging err value here as we have no access to the original cause for abort.

@gmalouf gmalouf requested a review from algorandskiy July 8, 2024 15:41
@onetechnical
Copy link
Contributor

I'm not sure if we want to just drop these messages completely. The two contexts I see this firing for recently are:

  • no block available for given round
  • Get \"http://RELAYAdDR/v1/NETWORK-v1.0/block/BLOCKID\": context canceled

@algorandskiy algorandskiy changed the title Skip logging err value for catchup abort as it is not available in this context catchup: skip logging err for catchup cancellation Jul 8, 2024
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchAndWrite(%v) vs fetchAndWrite(%d) is inconsistent in this file, all need to be %d (or %v) eventually.

@algorandskiy
Copy link
Contributor

Please rebase/merge master - it as some flaky test fixes.

@urtho urtho force-pushed the urtho-faw-logging branch from 0714a9e to 62780a6 Compare July 15, 2024 19:25
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.11%. Comparing base (48a539f) to head (62780a6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6053      +/-   ##
==========================================
- Coverage   56.13%   56.11%   -0.02%     
==========================================
  Files         488      488              
  Lines       69439    69439              
==========================================
- Hits        38978    38965      -13     
- Misses      27813    27821       +8     
- Partials     2648     2653       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy requested a review from cce July 18, 2024 19:48
Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you really want to see every error you can turn on debug-level logging. the ctx.Done() will occur when pipelinedFetch() finishes, so the reasons for it finishing would be logged inside pipelinedFetch.

@algorandskiy algorandskiy merged commit 75bb6a9 into algorand:master Jul 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants