algod: fix telemetry lookup if phonebook is used #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmalouf
approved these changes
Jul 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6061 +/- ##
==========================================
- Coverage 56.16% 56.14% -0.02%
==========================================
Files 488 488
Lines 69432 69432
==========================================
- Hits 38995 38982 -13
- Misses 27792 27796 +4
- Partials 2645 2654 +9 ☔ View full report in Codecov by Sentry. |
cce
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In rare case of using phonebook only addresses AND enabling telemetry, telemetry DNS lookup would be skipped due to empty DNSBootstrapID.
Test Plan
Existing tests