-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: support EnableGossipService in p2p streams #6073
p2p: support EnableGossipService in p2p streams #6073
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6073 +/- ##
==========================================
+ Coverage 55.95% 56.30% +0.34%
==========================================
Files 488 488
Lines 69602 69595 -7
==========================================
+ Hits 38945 39182 +237
+ Misses 27967 27763 -204
+ Partials 2690 2650 -40 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One still is receiving blocks and certs when gossip service is disabled right? Do we doublecheck that/is it worth doublechecking that?
Merged master into |
Summary
Added
EnableGossipService
support to p2p net: stream manager checks connection direction and either does not open a new/algorand-ws/1.0.0
(inConnected
notification) or closes incoming stream in a stream handler.Additionally I removed useless incoming vs outgoing checks with warnings since their assumption are wrong:
Connected
notification is fired for both incoming and outgoing connections.Test Plan
Added tests to ensure:
EnableGossipService=false
can still accept and send trafficEnableGossipService=false
cannot communicate.