txHandler: fix TestTxHandlerAppRateLimiter #6075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discovered in #5972 the TestTxHandlerAppRateLimiter had a typo.
This PR fixed it by crafting workload to make sure ARL in txHandler is getting actually called.
While debugging I noticed that
maxBucketSize
is set to 1 ifTxBacklogAppTxRateLimiterMaxSize
is less than 128 (number of buckets). Although this was not an issue in production due toTxBacklogAppTxRateLimiterMaxSize=1048576
it would trigger eviction on each insert that makes ARL noop. SettingmaxBucketSize
to 2 as its min value makes it working in such extreme configuration.Test Plan
This is a test fix
Closes #5972