Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix mac universal rebuild for nightlies #6084

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Jul 26, 2024

Summary

Introduced a bug in #6071 because build deps are not in that stage.

Because we rebuild for the universal target for nightlies on darwin, we need build dependencies. This modifies deploy packages to call the build script to install for this case.

(Also removed a small case for linux-arm, since that's deprecated.)

Test Plan

Ran manually to ensure it triggered properly.

@onetechnical onetechnical self-assigned this Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.26%. Comparing base (2b34eda) to head (7a6a65f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6084      +/-   ##
==========================================
- Coverage   56.27%   56.26%   -0.02%     
==========================================
  Files         488      488              
  Lines       69587    69587              
==========================================
- Hits        39157    39150       -7     
- Misses      27771    27775       +4     
- Partials     2659     2662       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy requested review from cce and jasonpaulos July 26, 2024 20:30
@algorandskiy algorandskiy merged commit 04ec5f9 into master Jul 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants