Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: fix broken ci-build target #6087

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

onetechnical
Copy link
Contributor

@onetechnical onetechnical commented Jul 29, 2024

Summary

In #6071 the build dependency was removed from the ci-build target. This meant that it would not build the binary before trying to package up the files.

Test Plan

Ran ci-build from a containerized environment to verify.

@onetechnical onetechnical self-assigned this Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.28%. Comparing base (a9c2b7e) to head (d55440c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6087      +/-   ##
==========================================
+ Coverage   56.26%   56.28%   +0.02%     
==========================================
  Files         488      488              
  Lines       69607    69607              
==========================================
+ Hits        39166    39181      +15     
+ Misses      27783    27768      -15     
  Partials     2658     2658              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy algorandskiy merged commit e697ae8 into algorand:master Jul 29, 2024
19 of 20 checks passed
@onetechnical onetechnical deleted the ci-build-debug branch July 29, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants