tests: fix flushing in TestVotersReloadFromDiskAfterOneStateProofCommitted #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itted The test in question uses a combination of automatic commits and a manual commit triggering. Stopping commitSyncer in the middle of the test creates a race condition between enqueueing and consuming - it is likely a task enqueued after commitSyncer is done draining and exiting. This leaves us with one element in deferredCommits (that is OK) and one extra accountsWriting wait group element (not OK on close if commitSyncer is active). Given a later reloadLedger call leads to restarting commitSyncer, re-initalization the queue but preserving accountsWriting value that is one off and drives infinite wait on closing. The fix is just updates the test to prevent the race above. It is also possible to reset accountsWriting in trackerRegistry.initialize but it looks useful to catch closing errors in our unit tests exercising various closing scenarios.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6090 +/- ##
==========================================
+ Coverage 55.85% 56.26% +0.41%
==========================================
Files 488 488
Lines 69610 69610
==========================================
+ Hits 38879 39167 +288
+ Misses 28045 27787 -258
+ Partials 2686 2656 -30 ☔ View full report in Codecov by Sentry. |
cce
approved these changes
Jul 31, 2024
jasonpaulos
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The test in question uses a combination of automatic commits and a manual commit triggering. Stopping commitSyncer in the middle of the test creates a race condition between enqueueing and consuming - it is likely a task enqueued after commitSyncer is done draining and exiting. This leaves us with one element in deferredCommits (that is OK) and one extra accountsWriting wait group element (not OK on close if commitSyncer is active). Given a later reloadLedger call leads to restarting commitSyncer, re-initalization the queue but preserving accountsWriting value that is one off and drives infinite wait on closing.
The fix is just updates the test to prevent the race above. It is also possible to reset accountsWriting in trackerRegistry.initialize but it looks useful to catch closing errors in our unit tests exercising various closing scenarios.
Failure sample with debug logs from #6088
Test Plan
This is a test fix.