-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: Add algod_network_p2p_* traffic metrics #6105
Merged
algorandskiy
merged 16 commits into
algorand:master
from
algorandskiy:pavel/p2p-network-metrics
Aug 29, 2024
Merged
p2p: Add algod_network_p2p_* traffic metrics #6105
algorandskiy
merged 16 commits into
algorand:master
from
algorandskiy:pavel/p2p-network-metrics
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6105 +/- ##
==========================================
+ Coverage 56.22% 56.30% +0.08%
==========================================
Files 490 490
Lines 69705 69746 +41
==========================================
+ Hits 39191 39271 +80
+ Misses 27840 27809 -31
+ Partials 2674 2666 -8 ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/p2p-network-metrics
branch
from
August 19, 2024 23:56
34f8746
to
0fe5308
Compare
cce
reviewed
Aug 20, 2024
cce
reviewed
Aug 20, 2024
cce
reviewed
Aug 20, 2024
cce
reviewed
Aug 20, 2024
algorandskiy
changed the title
p2p: Add algod_network_p2p_sent_bytes_{TAG} metrics
p2p: Add algod_network_p2p_* traffic metrics
Aug 21, 2024
cce
reviewed
Aug 22, 2024
algorandskiy
force-pushed
the
pavel/p2p-network-metrics
branch
from
August 22, 2024 21:46
1cc9a9c
to
c95cb91
Compare
algorandskiy
force-pushed
the
pavel/p2p-network-metrics
branch
from
August 23, 2024 01:37
ca25a1a
to
72f89c8
Compare
cce
approved these changes
Aug 28, 2024
gmalouf
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a part 2 of the P2P metrics enhancement (followup to the #6104)
network/metrics.go
since they now also p2p metricsalgod_network_p2p_received_bytes_{TAG}
,algod_network_p2p_sent_bytes_{TAG}
,algod_network_p2p_message_sent_{TAG}
,algod_network_p2p_message_received_{TAG}
algod_network_p2p_
oralgod_network_
counters based on a node type.pubsubMetricsTracer
increments*_TX
counters.pubsubMetricsTracer
has hardcodedTX
toTXTopicName
mapping because of these reasons:*rpc.Publish[i].Topic == TXTopicName
is optimized down to two comparison instructions: length and data (given the topic name is 8 bytes).Test Plan
goal network
+pingpong
+test/heapwatch/heapWatch.py --period 10 --metrics
and observed