tests: fix a race in TestP2PwsStreamHandlerDedup #6116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There were couple failures in TestP2PwsStreamHandlerDedup caused by too early check on the second node - before it had a chance to handle connection closure and remove unsuccessful peer.
Additionally, there is also an attempt to fix
TestCapabilities_Discovery
that works on non-connected p2p hosts, manually adds peers to DHT routing table and then compares the table expected size.Not sure what exactly it was testing (adding to routing table and checking its size looks unusual) but there is a race between
capD.dht.ForceRefresh()
andcapD.dht.RoutingTable().Size()
since as soon as it completes it prunes all non-reachable peers (and they all unreachable).Having said that the test looks quite useless so I removed it.
Test Plan
This is a test fix.