-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix expect tests and add EOF linter #6122
tests: fix expect tests and add EOF linter #6122
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6122 +/- ##
==========================================
- Coverage 56.22% 56.20% -0.03%
==========================================
Files 494 494
Lines 69921 69921
==========================================
- Hits 39313 39299 -14
- Misses 27941 27954 +13
- Partials 2667 2668 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some eof
s looks exceeding because of variables checking after the expect
statement but does not hurt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 1 ask in Makefile - is the idea that eof wasn't being called in some corner cases/we ended up with false positives?
Summary
While looking why #6089 expect test did not work as expected, I found it copied the
expect
statement from theCheckNetworkAddressForCors
function, and it does not perform check correctly ignoring the fact of missing expected output.I fixed that by added
eof
sub statement which is hit when no other statement executed previously and when there is noexp_continue
. After that the test started failing since it was checking KMD headers without settingallowed_origins
configuration option.@cce also discovered the same issue in some other tests and added a linter.
Test Plan
This is a test fix.