-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network: handle p2p to ws messages propagation #6156
Merged
algorandskiy
merged 5 commits into
algorand:master
from
algorandskiy:pavel/p2p-tx-hybrid
Nov 19, 2024
Merged
network: handle p2p to ws messages propagation #6156
algorandskiy
merged 5 commits into
algorand:master
from
algorandskiy:pavel/p2p-tx-hybrid
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
gmalouf
reviewed
Nov 18, 2024
gmalouf
previously approved these changes
Nov 18, 2024
cce
approved these changes
Nov 18, 2024
gmalouf
approved these changes
Nov 18, 2024
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a pure p2p node sends a transaction to a hybrid node, it gets stuck in p2p-only gossipsub mesh due to missing
Relay
call. Fixed by addingnet.BridgeP2PToWS
call to the validation pipeline in tx handler.BridgeP2PToWS
is done under a type assertion and only implemented by a hybrid net so no extra work is done.Test Plan
Added a new unit test