Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: handle p2p to ws messages propagation #6156

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Oct 25, 2024

Summary

When a pure p2p node sends a transaction to a hybrid node, it gets stuck in p2p-only gossipsub mesh due to missing Relay call. Fixed by adding net.BridgeP2PToWS call to the validation pipeline in tx handler.
BridgeP2PToWS is done under a type assertion and only implemented by a hybrid net so no extra work is done.

Test Plan

Added a new unit test

@algorandskiy algorandskiy requested review from cce and gmalouf October 25, 2024 21:49
@algorandskiy algorandskiy self-assigned this Oct 25, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.92%. Comparing base (7d4e23b) to head (7b0e4a0).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
data/txHandler.go 0.00% 1 Missing and 1 partial ⚠️
network/hybridNetwork.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6156      +/-   ##
==========================================
+ Coverage   51.86%   51.92%   +0.06%     
==========================================
  Files         639      639              
  Lines       85435    85439       +4     
==========================================
+ Hits        44309    44363      +54     
+ Misses      38324    38272      -52     
- Partials     2802     2804       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

data/txHandler.go Outdated Show resolved Hide resolved
gmalouf
gmalouf previously approved these changes Nov 18, 2024
@algorandskiy algorandskiy merged commit ce9b2b0 into algorand:master Nov 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants