Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix MaxConnectionsPerIP setting in agreement/gossip tests #6173

Merged

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Nov 19, 2024

Summary

#6171 decreased MaxConnectionsPerIP default value and it is not enough for agreement/gossip tests.
Here is a failure example for reference.

Test Plan

agreement/gossip tests pass

* algorand#6171 decreased MaxConnectionsPerIP default value and it is not
  enough for agreement/gossip tests
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.86%. Comparing base (a6123b6) to head (e7be338).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6173      +/-   ##
==========================================
+ Coverage   51.84%   51.86%   +0.02%     
==========================================
  Files         639      639              
  Lines       85488    85488              
==========================================
+ Hits        44319    44340      +21     
+ Misses      38360    38340      -20     
+ Partials     2809     2808       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gmalouf gmalouf merged commit db7f162 into algorand:master Nov 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants