-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CICD: Update Chromedriver version and CI orb #802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
changed the title
Update Chromedriver link 115>=
Update Chromedriver link >=115
Jul 20, 2023
algochoi
changed the title
Update Chromedriver link >=115
CI: Update Chromedriver link >=115
Jul 20, 2023
algochoi
changed the title
CI: Update Chromedriver link >=115
CICD: Update Chromedriver link >=115
Jul 20, 2023
algochoi
changed the title
CICD: Update Chromedriver link >=115
CICD: Update Chromedriver link
Jul 20, 2023
algochoi
changed the title
CICD: Update Chromedriver link
CICD: Update Chromedriver version and CI orb
Jul 20, 2023
algobarb
approved these changes
Jul 20, 2023
Eric-Warehime
approved these changes
Jul 20, 2023
algochoi
added a commit
that referenced
this pull request
Jul 20, 2023
* Update Chromedriver link 115>= * Use puppeteer to download latest stable chromedriver * Update circle ci browser tools orb * Don't manually install chromedriver * Pin chromedriver version * Remove comment * Revert to 114 * Update selenium * Test * Update chromedriver 114
This was referenced Aug 16, 2023
joe-p
pushed a commit
to joe-p/js-algorand-sdk
that referenced
this pull request
Apr 11, 2024
* Update Chromedriver link 115>= * Use puppeteer to download latest stable chromedriver * Update circle ci browser tools orb * Don't manually install chromedriver * Pin chromedriver version * Remove comment * Revert to 114 * Update selenium * Test * Update chromedriver 114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromedriver v115+ now ships with Chrome. npm's chromedriver does support this from v114 and onwards.
Also updates the CircleCI
browser-tools
orb that fixes a Chrome v115+ issue: CircleCI-Public/browser-tools-orb#81Fixes CI failures on chrome.