Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dubbo version to 2.6.x in sentinel-dubbo-adapter and demo #617

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Mar 26, 2019

Describe what this PR does / why we need it

Update Dubbo version to 2.6.x in sentinel-dubbo-adapter and demo, since Dubbo 2.5.x will be end-of-life soon.

Does this pull request fix one issue?

NONE

Describe how you did it

Simply update the Dubbo version to 2.6.6.

Describe how to verify it

Run the demo.

Special notes for reviews

Plz also test for using Dubbo 2.5.x with the adapter.

- because Dubbo 2.5.x will be deprecated soon

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added to-review To review area/integrations Issues or PRs related to integrations with open-source components labels Mar 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #617 into master will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #617      +/-   ##
============================================
+ Coverage     39.83%   40.31%   +0.48%     
- Complexity     1274     1288      +14     
============================================
  Files           278      278              
  Lines          8832     8832              
  Branches       1183     1183              
============================================
+ Hits           3518     3561      +43     
+ Misses         4869     4812      -57     
- Partials        445      459      +14
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/LeapArray.java 70.58% <0%> (-1.97%) 34% <0%> (-1%)
...l/cluster/server/connection/ConnectionManager.java 76% <0%> (+2%) 11% <0%> (+1%) ⬆️
...a/com/alibaba/csp/sentinel/eagleeye/StatEntry.java 20.21% <0%> (+2.12%) 8% <0%> (+1%) ⬆️
...alibaba/csp/sentinel/eagleeye/StatRollingData.java 73.52% <0%> (+2.94%) 9% <0%> (+1%) ⬆️
...a/csp/sentinel/slots/statistic/base/LongAdder.java 34.04% <0%> (+17.02%) 11% <0%> (+7%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 60.41% <0%> (+34.37%) 10% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d92b8...a5ef998. Read the comment docs.

Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 7f29773 into master Mar 27, 2019
@sczyh30 sczyh30 removed the to-review To review label Mar 27, 2019
@sczyh30 sczyh30 added this to the 1.5.1 milestone Mar 27, 2019
@sczyh30 sczyh30 deleted the upgrade-dubbo-version branch March 27, 2019 02:55
blindpirate pushed a commit to blindpirate/Sentinel that referenced this pull request Apr 10, 2019
…baba#617)

because Dubbo 2.5.x will be deprecated soon

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issues or PRs related to integrations with open-source components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants