Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metric new #1015

Merged
merged 43 commits into from
Aug 24, 2023
Merged

add metric new #1015

merged 43 commits into from
Aug 24, 2023

Conversation

linrunqi08
Copy link
Collaborator

@linrunqi08 linrunqi08 commented Jul 14, 2023 •
edited
Loading

核心文件：
core/monitor/LogtaiMetric.cpp
core/monitor/LogtaiMetric.h
core/monitor/MetricExportor.cpp
core/monitor/MetricExportor.h

测试：
core/unittest/monitor/LogtailMetricUnittest.cpp

messixukejia
messixukejia reviewed Jul 24, 2023
View reviewed changes
core/CMakeLists.txt Outdated Show resolved Hide resolved
core/logtail.cpp Outdated Show resolved Hide resolved
core/CMakeLists.txt Outdated Show resolved Hide resolved
linrunqi08
linrunqi08 commented Aug 1, 2023
View reviewed changes
core/ilogtail_metric/ILogtaiMetric.cpp Outdated Show resolved Hide resolved
core/ilogtail_metric/ILogtaiMetric.cpp Outdated Show resolved Hide resolved
core/CMakeLists.txt Outdated Show resolved Hide resolved
core/logtail.cpp Outdated Show resolved Hide resolved
core/CMakeLists.txt Outdated Show resolved Hide resolved
messixukejia
messixukejia approved these changes Aug 1, 2023
View reviewed changes
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/CMakeLists.txt Show resolved Hide resolved
core/CMakeLists.txt
controller event event_handler event_listener helper log_pb logger monitor
parser plugin polling processor profiler reader profile_sender sender shennong sdk
controller event event_handler event_listener helper log_pb logger monitor
parser plugin polling processor reader profile_sender sender shennong sdk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档增加一个开发指南吧

core/unittest/monitor/LogtailMetricUnittest.cpp Outdated Show resolved Hide resolved
yyuuttaaoo
yyuuttaaoo requested changes Aug 22, 2023
View reviewed changes
core/unittest/monitor/LogtailMetricUnittest.cpp Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
yyuuttaaoo
yyuuttaaoo requested changes Aug 23, 2023
View reviewed changes
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
henryzhx8
henryzhx8 requested changes Aug 23, 2023
View reviewed changes
core/monitor/LogtailMetric.h Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
henryzhx8
henryzhx8 requested changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@henryzhx8 henryzhx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件后都加上一行空行

core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
core/monitor/LogtaiMetric.cpp Outdated Show resolved Hide resolved
core/monitor/LogtailMetric.h Outdated Show resolved Hide resolved
@linrunqi08 linrunqi08 merged commit 733f853 into main Aug 24, 2023
22 checks passed
@yyuuttaaoo yyuuttaaoo deleted the feature/taiye/add_metric_new branch August 25, 2023 15:54
@yyuuttaaoo yyuuttaaoo added this to the v1.8 milestone Sep 26, 2023
@yyuuttaaoo yyuuttaaoo added the feature request New feature request label Sep 26, 2023
@linrunqi08 linrunqi08 changed the title [WIP]: add metric new add metric new Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryzhx8 henryzhx8 henryzhx8 approved these changes

@messixukejia messixukejia messixukejia approved these changes

@yyuuttaaoo yyuuttaaoo yyuuttaaoo approved these changes

Assignees
No one assigned
Labels
feature request New feature request
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@linrunqi08 @yyuuttaaoo @messixukejia @henryzhx8